Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a querying example into the main readme #515

Merged
merged 5 commits into from
Sep 29, 2020
Merged

docs: add a querying example into the main readme #515

merged 5 commits into from
Sep 29, 2020

Conversation

IlyaFaer
Copy link
Contributor

No description provided.

@IlyaFaer IlyaFaer added type: docs Improvement to the documentation for an API. api: spanner Issues related to the googleapis/python-spanner-django API. labels Sep 18, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2020
@IlyaFaer IlyaFaer requested a review from c24t September 18, 2020 10:51
@IlyaFaer
Copy link
Contributor Author

IlyaFaer commented Sep 18, 2020 •
edited
Loading

Usually there is a small sample of how to use API in the main readme (see Storage, Firestore, PubSub), like an API preview. And it's strange that we have configurations examples, but not usage examples.

@mf2199 mf2199 requested a review from a team as a code owner September 29, 2020 02:28
@mf2199 mf2199 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020
mf2199
mf2199 reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@mf2199 mf2199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An indentation remark.

README.rst Outdated Show resolved Hide resolved
@IlyaFaer IlyaFaer added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020
@mf2199 mf2199 self-requested a review September 29, 2020 19:11
@mf2199 mf2199 merged commit c477cc2 into master Sep 29, 2020
@IlyaFaer IlyaFaer deleted the IlyaFaer-readme_example branch September 30, 2020 06:54
This was referenced Apr 17, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mf2199 mf2199 mf2199 approved these changes

@c24t c24t Awaiting requested review from c24t

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IlyaFaer @mf2199 @yoshi-kokoro